New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'types' override in .lagoon.yml doesn't work on environments with a dot in their name #818

Closed
erikrs opened this Issue Dec 20, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@erikrs
Copy link
Contributor

erikrs commented Dec 20, 2018

I try to override type in .lagoon.yml with mariadb-shared but doesn't work:

environments:
  dev.platform.aiv:
    types:
      mariadb: mariadb-shared

But it isn't captured during build:

+++ cat .lagoon.yml
+++ shyaml get-value environments.dev.platform.aiv.types.mariadb false
++ ENVIRONMENT_SERVICE_TYPE_OVERRIDE=false

line 245 in \lagoon\images\oc-build-deploy-dind\build-deploy-docker-compose.sh:

SERVICE_TYPE_OVERRIDE=$(cat .lagoon.yml | shyaml get-value environments.${BRANCH}.types.$SERVICE_NAME false)

should be

SERVICE_TYPE_OVERRIDE=$(cat .lagoon.yml | shyaml get-value environments.${BRANCH//./\\.}.types.$SERVICE_NAME false)

(in analogy with eg. 'routes' as in:

$(cat .lagoon.yml | shyaml keys ${PROJECT}.environments.${BRANCH//./\\.}.routes.$ROUTES_SERVICE_COUNTER

Schnitzel added a commit that referenced this issue Dec 21, 2018

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Jan 22, 2019

fixed: #813

@Schnitzel Schnitzel closed this Jan 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment