Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes definition with tls-acme parsing problem - DNS-1123 subdomain must consist of lower case alphanumeric characters... #915

Closed
twerthmueller opened this Issue Feb 26, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@twerthmueller
Copy link
Contributor

twerthmueller commented Feb 26, 2019

We had a problem with the deployment when we had defined the tls-acme value in .lagoon.yml:

Error from server (Invalid): Route "vse.ch:\n tls-acme: 'false'" is invalid: [metadata.name: Invalid value: "vse.ch:\n tls-acme: 'false'": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*'), spec.host: Invalid value: "vse.ch:\n tls-acme: 'false'": host must conform to DNS 952 subdomain conventions]

We have added the config as described here: https://lagoon.readthedocs.io/en/latest/using_lagoon/lagoon_yml/

strom ch 2019-02-26 14-37-20

Looks like that there is a problem with the line break.

@marji

This comment has been minimized.

Copy link
Contributor

marji commented Mar 14, 2019

I can confirm I'm also affected by this issue. I tried all different kind of spacing in the routes section, I used yamlling on the .lagoon.yml file, but I keep getting this error.

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Mar 29, 2019

mhh unfortunately I cannot reproduce this:

oc-build-deploy-dind:/oc-build-deploy/git$ cat test.yml
site:
  environments:
    master:
      routes:
        - varnish:
          - "strom.ch"
          - "www.strom.ch"
          - "vse.ch":
              tls-acme: 'false'
          - "www.vse.ch"
          - "poweron.ch"

oc-build-deploy-dind:/oc-build-deploy/git$ cat test.yml | shyaml keys site.environments.master.routes.0.varnish.2 | sed 's/\./\\./g'
vse\.ch
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Mar 29, 2019

@marji @twerthmueller
can you paste the yaml you tried with in here?

@marji

This comment has been minimized.

Copy link
Contributor

marji commented Mar 29, 2019

@Schnitzel Here is my config (I just redacted the domain names)

polysite1:
  environments:
    master:
      routes:
        - nginx:
          - "www.polysite1.org.au":
              tls-acme: 'false'
          - "polysite1.org.au":
              tls-acme: 'false'
          - polysite1-prod.org.net
@twerthmueller

This comment has been minimized.

Copy link
Contributor Author

twerthmueller commented Mar 29, 2019

@Schnitzel I send you the yaml over Slack.

Schnitzel added a commit that referenced this issue Mar 29, 2019

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Mar 29, 2019

found it! thanks @twerthmueller and @marji for the help
#1007

Schnitzel added a commit that referenced this issue Mar 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.