Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the DeleteSshKeyById API endpoint. #1147

Merged
merged 3 commits into from Nov 20, 2019
Merged

Adding the DeleteSshKeyById API endpoint. #1147

merged 3 commits into from Nov 20, 2019

Conversation

@cdchris12
Copy link
Contributor

cdchris12 commented Jul 10, 2019

This PR adds the DeleteSshKeyById GrpahQL API endpoint, which should help us ensure we are deleting the correct SSH key, as multiple SSH keys can possibly share the same key name.

Changelog Entry

Improvement - Adds the DeleteSshKeyById GraphQL API route.

Closing issues

Closes #1145

@cdchris12 cdchris12 requested a review from Schnitzel Jul 10, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Aug 21, 2019

this will need some additional work for RBAC, pushing to 1.1.0

@Schnitzel Schnitzel added this to the v1.1.0 milestone Aug 21, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Sep 7, 2019

@rocketeerbkw please check for RBAC additions.

@Schnitzel Schnitzel modified the milestones: v1.1.0, v1.2.0 Sep 27, 2019
cdchris12 and others added 2 commits Jul 10, 2019
@rocketeerbkw

This comment has been minimized.

Copy link
Member

rocketeerbkw commented Oct 10, 2019

Rebased with master and updated for RBAC

@rocketeerbkw rocketeerbkw removed their assignment Oct 10, 2019
@Schnitzel Schnitzel merged commit cab978d into master Nov 20, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@rocketeerbkw rocketeerbkw deleted the 1145 branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.