Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PHP notices on production envs by default #1162

Merged
merged 9 commits into from Sep 8, 2019

Conversation

@cdchris12
Copy link
Contributor

commented Jul 31, 2019

This commit disables PHP notices by default on all production environments so as to prevent those notices from being logged to the watchdog process.

This behavior can be overridden by setting the environment variable production_notices to true.

Changelog Entry

Change - Disable PHP notices on production environments by default


## Special Environment Variables

### `PHP_ERROR_REPORTING`

This comment has been minimized.

Copy link
@Schnitzel

This comment has been minimized.

Copy link
@cdchris12

cdchris12 Sep 7, 2019

Author Contributor

Added in d9c6f36 . Would you like to remove this block from docs/using_lagoon/environment_variables.md as well? @Schnitzel

images/php/fpm/entrypoints/51-production-detection.sh Outdated Show resolved Hide resolved
@Schnitzel Schnitzel added this to the v1.1.0 milestone Aug 21, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

commented Sep 7, 2019

@cdchris12 can you have a look at my requests?

@cdchris12

This comment has been minimized.

Copy link
Contributor Author

commented Sep 7, 2019

Sorry about that; somehow missed the notification of your previous comments. I'll get them resolved on Monday. :)

cdchris12 added 4 commits Sep 7, 2019
@Schnitzel Schnitzel merged commit 523eb27 into master Sep 8, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.