Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lagoonize.md #1163

Merged
merged 1 commit into from Aug 21, 2019

Conversation

@JohnAlbin
Copy link
Contributor

commented Aug 1, 2019

Don't use "here" as link text; accessibility software usually has a "read all the links to me so I can choose the appropriate one to follow" action and hearing "here" is completely useless.

Also, you are using Winnie-the-Pooh-style capitalization in A Few Places, which is Cute for a Children's Book, but looks Odd in This Context.

Lastly, I don't see anything about why you would need to ”add patches directory if you choose drupal8-composer-mariadb“. Is this step still needed? If not, remove it. If it is, you would also need to update the Dockerfile.cli file to un-comment COPY patches /app/patches, right?

Update lagoonize.md
Don't use "here" as link text; accessibility software usually has a "read all the links to me so I can choose the appropriate one to follow" action and hearing "here" is completely useless. Also, you are using Winnie-the-Pooh-style capitalization in A Few Places, which is Cute for a Children's Book, but looks Odd in This Context.

Lastly, I don't see anything about why you would need to “add `patches` directory if you choose drupal8-composer-mariadb”. Is this step still needed? If not, remove it. If it is, you would also need to update the `Dockerfile.cli` file to un-comment `COPY patches /app/patches`, right?
@twardnw
twardnw approved these changes Aug 5, 2019

@Schnitzel Schnitzel merged commit d23c444 into amazeeio:master Aug 21, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@Schnitzel Schnitzel added this to the v1.0.0 RBAC milestone Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.