Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Deployments Improvements #1165

Merged
merged 8 commits into from Nov 20, 2019
Merged

UI Deployments Improvements #1165

merged 8 commits into from Nov 20, 2019

Conversation

@rocketeerbkw
Copy link
Member

rocketeerbkw commented Aug 3, 2019

This PR addresses a number of issues related to deployments shown in the UI. See changelog for more details.

  1. New button style and help text added to the deploy button to reduce confusion. The help text is deploy type aware:

image

image

image

  1. New API mutation and button in UI to cancel running/stuck deployments
    image
mutation cancelDeployment {
  cancelDeployment(input: {
    deployment:{
      name: "lagoon-11"
      environment: {
        name:"drupal8-composer-73-mariadb"
        project:{
          name: "ci-drupal"
        }
      }
    }
  })
}

The mutation makes some changes to the RBAC permissions:

  • Deployment resource has a new scope cancel
  • cancelDeployment requires users to be at least maintainers for the project

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Explain the details for making this change. What existing problem does the pull request solve?

Changelog Entry

Improvement - Environment deploy button help text and site-wide button styles (#1013)
Improvement - Add cancelDeployment API mutation
Improvement - Add button in UI to cancel running/stuck deployments (#1155)
Bugfix - Environments of type "promote" were not marked as such on the environments page

Closing issues

Closes #1013, Closes #1155

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Sep 20, 2019

@rocketeerbkw can you fix the conflict? Plus is this still in WIP?

@Schnitzel Schnitzel modified the milestones: v1.1.0, v1.2.0 Oct 1, 2019
rocketeerbkw added 5 commits Aug 3, 2019
tobybellwood and others added 2 commits Nov 19, 2019
@Schnitzel Schnitzel merged commit 69fa155 into master Nov 20, 2019
@Schnitzel Schnitzel deleted the ui-deployment-improvements branch Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.