Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 #1216

Merged
merged 7 commits into from Sep 19, 2019

Conversation

@cdchris12
Copy link
Contributor

commented Sep 2, 2019

This commit enables the use of Node version 12 containers.

Changelog Entry

Feature - Added containers for Node version 12

Possibly related to #1157

dasrecht and others added 2 commits Sep 2, 2019
@cdchris12 cdchris12 requested a review from dasrecht Sep 2, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

commented Sep 2, 2019

can we also get some tests for node12? looks like currently we only test node6 and node8, so we should probably add test for 10 and 12 :)

cdchris12 added 3 commits Sep 9, 2019
@cdchris12 cdchris12 requested review from Schnitzel and removed request for dasrecht Sep 9, 2019
@Schnitzel Schnitzel merged commit 6eaa546 into master Sep 19, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.