Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize getBackupsByEnvironmentId #1223

Merged
merged 6 commits into from Sep 8, 2019

Conversation

@rocketeerbkw
Copy link
Member

commented Sep 4, 2019

During backups, the load on the api-db gets quite high. One of the suspect queries was caused by the getBackupsByEnvironmentId resolver. I removed a join and added an index, which should speed up these queries.

I also noticed that the Backup > Environment resolver was just missing and has been forever. So added that.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Explain the details for making this change. What existing problem does the pull request solve?

Changelog Entry

Bugfix - Fix API slowness in getBackupsByEnvironmentId resolver (#1180)
Bugfix - Resolver for Backup > Environment was missing

Closing issues

closes #1180

rocketeerbkw and others added 6 commits Sep 4, 2019
@Schnitzel Schnitzel merged commit 95b07ef into master Sep 8, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@rocketeerbkw rocketeerbkw deleted the 1180-optimize-backups-tables branch Sep 19, 2019
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.