Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbac doc changes #1237 #1245

Merged
merged 8 commits into from Sep 24, 2019

Conversation

@jaimed-amazee
Copy link
Contributor

commented Sep 11, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Explain the details for making this change. What existing problem does the pull request solve?

Changelog Entry

Closing issues

closes #1237

@jaimed-amazee jaimed-amazee requested a review from twardnw Sep 11, 2019
Copy link
Member

left a comment

A few things to look at for you :)

docs/administering_lagoon/create-project.gql Outdated Show resolved Hide resolved
docs/administering_lagoon/graphql_api.md Outdated Show resolved Hide resolved
docs/administering_lagoon/graphql_api.md Outdated Show resolved Hide resolved
docs/administering_lagoon/graphql_api.md Outdated Show resolved Hide resolved
docs/administering_lagoon/graphql_api.md Show resolved Hide resolved
docs/administering_lagoon/graphql_api.md Outdated Show resolved Hide resolved
docs/administering_lagoon/rbac.md Outdated Show resolved Hide resolved
@Schnitzel

This comment has been minimized.

Copy link
Member

commented Sep 20, 2019

@jaimed-amazee
Nice work! Just a couple of additions :)

@Schnitzel Schnitzel merged commit c423bb4 into master Sep 24, 2019
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.