Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removeNotificationFromProject mutation #1261

Merged
merged 2 commits into from Sep 25, 2019

Conversation

@rocketeerbkw
Copy link
Member

commented Sep 20, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The mutation removeNotificationFromProject throws a "Cannot destructure property projects of 'undefined' or 'null'." in lagoon v0.24 and a SQL syntax error in lagoon v1.0.0+.

The SQL error also exists in v0.24 but it's masked by a permissions passing error. This PR only addresses the issues in v1+.

Changelog Entry

Bugfix - Fix removeNotificationFromProject mutation (#1258)

Closing issues

closes #1258

rocketeerbkw and others added 2 commits Sep 20, 2019
@Schnitzel Schnitzel merged commit cef2d54 into master Sep 25, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.