Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace REDIS_PORT to REDIS_SERVICE_PORT #1263

Merged
merged 1 commit into from Sep 23, 2019

Conversation

@vincenzodnp
Copy link
Contributor

commented Sep 23, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The REDIS_PORT environment variable is not a "port" but a TCP address.
While REDIS_SERVICE_PORT is a variable set by Kube service discovery, with the TCP port Redis service is listening to.

Changelog Entry

Improvement - Use of REDIS_SERVICE_PORT instead of REDIS_PORT (#1254)

Closing issues

closes #1254

@vincenzodnp vincenzodnp requested a review from Schnitzel Sep 23, 2019
@Schnitzel Schnitzel merged commit 489764e into master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.