Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the variable to VARNISH_SET_HEADER_CACHE_TAGS #1264

Merged

Conversation

@vincenzodnp
Copy link
Contributor

commented Sep 23, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The default.vcl file has an if statement where the name of the variable (VARNISH_UNSET_HEADER_CACHE_TAGS) implies to disable a feature, while if set to true it does the opposite.
I renamed the variable in VARNISH_SET_HEADER_CACHE_TAGS, kept the default value to false, so feature is NOT enabled by default.

Changelog Entry

Bugfix - Renamed the VARNISH_UNSET_HEADER_CACHE_TAGS variable to VARNISH_SET_HEADER_CACHE_TAGS (#1049)

Closing issues

closes #1049

@vincenzodnp vincenzodnp requested a review from Schnitzel Sep 23, 2019
@Schnitzel Schnitzel merged commit 13934c7 into master Sep 23, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Schnitzel Schnitzel added this to the v1.1.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.