Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable elastic endpoints #1315

Merged

Conversation

@shreddedbacon
Copy link
Member

shreddedbacon commented Oct 17, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This change is to allow logs-db:9200 to be configurable, this means that either another elasticsearch can be used. Or a service with a ClusterIP can be used instead to reduce issues that can come with a headless service and DNS.

Changelog Entry

Improvement - Allow the api to use a configurable elasticsearch endpoint
Improvement - Allow the auto-idler to use a configurable elasticsearch endpoint

Closing issues

closes #1313

@tobybellwood

This comment has been minimized.

Copy link
Contributor

tobybellwood commented Oct 18, 2019

would this allow to specify an Elasticsearch located outside Lagoon?

@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Oct 18, 2019

Potentially

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Oct 20, 2019

@shreddedbacon
that's a great change, though I just switched to use logs-db-service by default (which exists since Lagoon 1.1.0

can you update this in this PR? thanks!

@Schnitzel Schnitzel self-requested a review Oct 20, 2019
Copy link
Member

Schnitzel left a comment

use logs-db-service by default, also check that this might cause issues for local development, where we probably need to come up with a clever way to handle this.

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Oct 23, 2019

nice idea! there are more places though where we should use this, see 47a53ea:

  • logs-forwarder
  • logs2logs-db
  • logs-db-curator
@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Oct 23, 2019

Yup, will work more on this shortly

@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 18, 2019

@shreddedbacon
please check https://github.com/amazeeio/lagoon/pull/1350/files which solves the problem of local logs-db-service in a more elegant version.
I still like the fact that we can define an external elasticsearch all together, but I think we don't need to have the logic switching between logs-db and logs-db-service for lagoon anymore

@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Nov 18, 2019

Agree, that is definitely more elegant. I'll re-work this to just allow for configurable ES endpoints only.

…ias, this removes unnecessary stuff
@shreddedbacon shreddedbacon force-pushed the shreddedbacon:configure-elastic-endpoints branch from 2abbc68 to 8fdee34 Dec 2, 2019
@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Dec 2, 2019

I've updated this branch to just being able to configure elastic endpoints using envvars, this goes along with needing #1350 to be merged too.

Schnitzel added 4 commits Dec 3, 2019
@Schnitzel Schnitzel merged commit 44c4772 into amazeeio:master Dec 9, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.