Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github usernames to closed Pull Requests #1332

Merged

Conversation

@dan2k3k4
Copy link
Contributor

dan2k3k4 commented Oct 21, 2019

Closes #1327

@Schnitzel Schnitzel merged commit 0b4b52f into amazeeio:master Oct 23, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Oct 23, 2019

@dan2k3k4
merged! thank you! but this will only work for closed PRs, I think in #1327 we're talking about completed builds for PRs? this is not really a close?

@dan2k3k4 dan2k3k4 deleted the dan2k3k4:add-github-username-to-closed-pr branch Oct 23, 2019
@dan2k3k4

This comment has been minimized.

Copy link
Contributor Author

dan2k3k4 commented Oct 23, 2019

@Schnitzel I believe the original question on slack was for closed PRs, and from what I can tell - we don't know who triggered the build only the PR? So I don't really see how we would solve "build completed by <PR sender user>" unless we track this at build notification too?

@tobybellwood tobybellwood added this to the v1.2.0 milestone Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.