Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Extract favicon nginx conf. #1334

Merged
merged 8 commits into from Dec 2, 2019

Conversation

@steveworley
Copy link
Contributor

steveworley commented Oct 22, 2019

Allows favicon.conf to be overriden by images that inherit the base and allows them to continue using the base Drupal configuration.

Changelog Entry

Improvement - Extracts favicon nginx configuration to an include file so that downstream images can override without inheriting the drupal.conf file (#1333 )

Closing issues

Closes #1333

- Allows favicon.conf to be overriden by images that inherit the base and allows them to continue using the base Drupal configuration.

Fixes 1333.
images/nginx-drupal/drupal/favicon.conf Outdated Show resolved Hide resolved
steveworley added 4 commits Nov 7, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019
steveworley and others added 2 commits Dec 2, 2019
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
@Schnitzel Schnitzel merged commit dd56fcb into amazeeio:master Dec 2, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.