Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task for running Drupal core-cron. #1346

Merged
merged 11 commits into from Nov 20, 2019
Merged

Conversation

@fubarhouse
Copy link
Contributor

fubarhouse commented Oct 26, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This change introduces a task in the API and UI to trigger Drush to run core-cron or core:cron. The change has previously been discussed directly and an issue for this exists where any discussion is yet to occur. (#1340)

I'd appreciate some guidance/feedback before marking this as ready, if it's possible 馃檪

Changelog Entry

  • Feature: Add cron task to UI to trigger Drush cron. (#1340)

Closing issues

fubarhouse added 3 commits Oct 26, 2019
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
Copy link
Contributor

seanhamlin left a comment

Nice work! Had a few comments.

Brings Drupal 7 & 8 in-line with the command call.

Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
fubarhouse added 2 commits Oct 28, 2019
Signed-off-by: Karl Hepworth <karl.hepworth@gmail.com>
@fubarhouse fubarhouse marked this pull request as ready for review Oct 28, 2019
@fubarhouse fubarhouse requested a review from seanhamlin Oct 29, 2019
services/keycloak/start.sh Outdated Show resolved Hide resolved
@Schnitzel Schnitzel requested a review from rocketeerbkw Nov 2, 2019
services/keycloak/start.sh Outdated Show resolved Hide resolved
@rocketeerbkw

This comment has been minimized.

Copy link
Member

rocketeerbkw commented Nov 4, 2019

This will conflict with #1165. Easiest is probably to merge this first, then fix conflicts over there.

fubarhouse added 2 commits Nov 4, 2019
For notes see #1346 (comment)
鈥t upgrade paths
@fubarhouse fubarhouse requested review from rocketeerbkw and Schnitzel Nov 4, 2019
docs/administering_lagoon/rbac.md Outdated Show resolved Hide resolved
services/keycloak/start.sh Show resolved Hide resolved
fubarhouse added 2 commits Nov 4, 2019
As per review #1346 (comment)
@tobybellwood tobybellwood added this to Lagoon 1.2.0 (Nov 2019) in Lagoon Roadmap (Indicative) Nov 11, 2019
@tobybellwood tobybellwood added this to the v1.2.0 milestone Nov 14, 2019
@Schnitzel Schnitzel merged commit 9abbff0 into amazeeio:master Nov 20, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can鈥檛 perform that action at this time.