Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs-db-service alias for logs-db when running locally #1350

Merged
merged 2 commits into from Dec 3, 2019

Conversation

@rocketeerbkw
Copy link
Member

rocketeerbkw commented Oct 29, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The hostname for the elasticsearch was recently changed to logs-db-service. This was not reflected in the hostname of the local logs-db container, so local isntances of logs2logs-db and logs-db-ui aren't able to connect. This change adds an alias so that logs-db-service resolves correctly locally (ie, with docker compose).

Changelog Entry

Bugfix - Add logs-db-service as a local alias for logs-db service

Closing issues

n/a

@tobybellwood

This comment has been minimized.

Copy link
Contributor

tobybellwood commented Oct 29, 2019

Does this resolve the local dev issue raised in #1315?

@rocketeerbkw

This comment has been minimized.

Copy link
Member Author

rocketeerbkw commented Oct 29, 2019

It resolved a current local dev issue where logs-db-ui and logs2logs-db can't connect to logs-db-service.

I'm not sure what other local issues might come up with #1315, since it looks like all the env vars will have defaults? As long as those use either logs-db or logs-db-service (with this PR) then it looks like it'd be fine. But I might be missing something.

@shreddedbacon shreddedbacon mentioned this pull request Dec 2, 2019
2 of 3 tasks complete
@Schnitzel Schnitzel added this to the v1.2.0 milestone Dec 3, 2019
@Schnitzel Schnitzel merged commit 8b1004e into master Dec 3, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@rocketeerbkw rocketeerbkw deleted the logs-db-service-alias branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.