Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos and .PHONY targets #1354

merged 1 commit into from Dec 1, 2019

Fix some typos and .PHONY targets #1354

merged 1 commit into from Dec 1, 2019


Copy link

smlx commented Oct 30, 2019

Fixes a few minor typos in the Makefile comments and .PHONY targets


  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This fixes the .PHONY to point to targets that exist in the Makefile.

Changelog Entry

Bugfix - update .PHONY targets in Makefile

Closing issues


@smlx smlx requested review from twardnw and Schnitzel Oct 30, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019

This comment has been minimized.

Copy link

Schnitzel commented Nov 27, 2019

@smlx can you check the merge conflict? Thanks!

@smlx smlx force-pushed the typos-makefile branch from f3d2343 to eaf9454 Nov 28, 2019

This comment has been minimized.

Copy link
Contributor Author

smlx commented Nov 28, 2019

@Schnitzel merge conflict fixed!

@Schnitzel Schnitzel merged commit 84b56b4 into master Dec 1, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
@smlx smlx deleted the typos-makefile branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.