Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use KVM as the minishift vm-driver on Linux #1355

Merged
merged 2 commits into from Nov 21, 2019
Merged

Conversation

@smlx
Copy link
Contributor

smlx commented Oct 30, 2019

Performance is far better than virtualbox, and it's the native/default hypervisor.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

KVM is the upstream recommended driver.

Changelog Entry

Improvement - Use the KVM driver for minishift on linux

Closing issues

n/a

Performance is far better than virtualbox.
@smlx smlx requested a review from twardnw Oct 30, 2019
@twardnw
twardnw approved these changes Nov 9, 2019
@dasrecht

This comment has been minimized.

Copy link
Member

dasrecht commented Nov 11, 2019

Looks good to me - testing this currently on testbed1 - the only issue i had that there were still some files in ~./minishift that lead to minishift still trying to interface with virtualbox.
After removing those everything started to work

@dasrecht

This comment has been minimized.

Copy link
Member

dasrecht commented Nov 11, 2019

The only thing missing would be adapting the documentation to send people towards - https://docs.okd.io/latest/minishift/getting-started/setting-up-virtualization-environment.html

For the testbed i created a ansible playbook to install the things needed - we could also opensource that part

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 11, 2019

this fails the automated testing, as it is running on Linux and the CI server does not have KVM installed.
Can we get KVM installed there before we merge this, or all the CI will fail ;)

@dasrecht

This comment has been minimized.

Copy link
Member

dasrecht commented Nov 11, 2019

yes sure - will work on that - actually got the whole thing scripted so it shoudln't be a big thing to get that started

@dasrecht dasrecht self-assigned this Nov 11, 2019
@smlx

This comment has been minimized.

Copy link
Contributor Author

smlx commented Nov 12, 2019

For reference, the required packages to install and group to add the test user to are here: https://wiki.debian.org/KVM#Installation

@dasrecht

This comment has been minimized.

Copy link
Member

dasrecht commented Nov 12, 2019

I'll run https://github.com/amazeeio/lagoon-testbed/blob/master/playbooks/lagoon-requisites.yml (non public yet) against our build system tomorrow so we can get the kvm builds also going

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 18, 2019

@dasrecht status update on this? We would like to add this to 1.2.0

@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019
@dasrecht

This comment has been minimized.

Copy link
Member

dasrecht commented Nov 19, 2019

I worked a bit on it and got it running on the testbed with 18.04 - sadly our CI host is on Ubuntu 16.04 which somehow has some broken KVM things which i first need to look into

Copy link
Contributor

vincenzodnp left a comment

As Makefile is currently set up, if you're on OSX you will run minishift by using Virtualbox driver while if on GNU/Linux with KVM. So, if you're on GNU/Linux and would like to run minishift with Virtualbox, you have to edit the Makefile before run make minishift.

Then, why not create a MINISHIFT_VM_DRIVER variable, set with default values depending on OS (so KVM for GNU/Linux and VirtualBox for OSX) but that could be easily overridden with MINISHIFT_VM_DRIVER=kvm make minishift?

@smlx

This comment has been minimized.

Copy link
Contributor Author

smlx commented Nov 21, 2019

@vincenzodnp maybe that can be a followup PR?

@dasrecht

This comment has been minimized.

Copy link
Member

dasrecht commented Nov 21, 2019

Yes let's do this as followup PR - I'll work on that lateron with @Schnitzel as we're adding a few new testing nodes that are on ubuntu 18.04 i'm fairly positive we won't need to fix this on 16.04 anymore.

Will check back at Standup and then update the ticket here.

@Schnitzel Schnitzel merged commit f3f7484 into master Nov 21, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@smlx smlx deleted the linux-minishift-driver branch Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.