Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploymentconfig test #1356

Merged
merged 3 commits into from Nov 26, 2019
Merged

Fix deploymentconfig test #1356

merged 3 commits into from Nov 26, 2019

Conversation

@smlx
Copy link
Contributor

smlx commented Oct 30, 2019

The existing test always returns true.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This change fixes the check for an existing deploymentconfig.

Changelog Entry

Bugfix - Fix check for an existing deploymentconfig in the rsh command.

Closing issues

n/a

The existing test always returns true.
@smlx smlx requested a review from Schnitzel Oct 30, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019
Schnitzel added 2 commits Nov 18, 2019
@Schnitzel Schnitzel merged commit 19da0ad into master Nov 26, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@smlx smlx deleted the fix-deploymentconfig-test branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.