Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch keycloak Dockerfile and entrypoint for new base image #1358

Merged
merged 1 commit into from Oct 31, 2019

Conversation

@smlx
Copy link
Contributor

smlx commented Oct 30, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The base image our keycloak is jboss/keycloak. This had a new release tagged, and as we don't currently pin base images against a tag we get latest when building from scratch. This new version has an incompatibility with our entrypoint scripts.

Therefore this PR implements the following:

  • install python2, as it is no longer part of the base image
  • enable script upload, as this is disabled by default in 7.0.1
  • pin base image version to 7.0.1 (current latest version)

Changelog Entry

Bugfix - Fix incompatibility and pin new upstream keycloak version

Closing issues

Supersedes #1352

* install python2, as it is no longer part of the base image
* enable script upload, as this is disabled by default in 7.0.1
* pin base image version to 7.0.1 (current latest version)
@smlx smlx requested a review from Schnitzel Oct 30, 2019
@tobybellwood tobybellwood mentioned this pull request Oct 31, 2019
2 of 3 tasks complete
@Schnitzel Schnitzel merged commit 75ceac8 into master Oct 31, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Oct 31, 2019

thanks @smlx !

@tobybellwood tobybellwood added this to the v1.2.0 milestone Dec 2, 2019
@smlx smlx deleted the patch-keycloak branch Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.