Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding toolbox container for operations purposes #1391

Merged
merged 7 commits into from Nov 26, 2019
Merged

adding toolbox container for operations purposes #1391

merged 7 commits into from Nov 26, 2019

Conversation

@dasrecht
Copy link
Member

dasrecht commented Nov 12, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Adding the toolbox container as i needed a ncdu and a mysqltuner recently

Changelog Entry

Improvement - Adding toolbox container

Closing issues

closes #800

@tobybellwood

This comment has been minimized.

Copy link
Contributor

tobybellwood commented Nov 12, 2019

Think this ties well into the conversation around #1306 too.

GovCMS built a CI helper image along similar lines over at https://github.com/govCMS/govcms-ci/blob/master/govcms-ci.Dockerfile

@dasrecht

This comment has been minimized.

Copy link
Member Author

dasrecht commented Nov 12, 2019

Oh didn't know about the GovCMS CI helper.

As for #1306 - As it's kind of a container we like to have close and add to it as we go i'd have it added directly. But we can split it off later if needed

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 12, 2019

@dasrecht the CI fails, can you check this? thanks

dasrecht added 2 commits Nov 12, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 18, 2019
Schnitzel and others added 4 commits Nov 18, 2019
…lbox
@Schnitzel Schnitzel merged commit 4c92977 into master Nov 26, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@dasrecht dasrecht deleted the 800-toolbox branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.