Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GraphQL to v14 #1414

Merged
merged 2 commits into from Nov 20, 2019
Merged

Upgrade GraphQL to v14 #1414

merged 2 commits into from Nov 20, 2019

Conversation

@JohnAlbin
Copy link
Contributor

JohnAlbin commented Nov 19, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated. n/a
  • Changelog entry has been written

The codebase currently uses graphql library 0.13.x. The latest version is 14.5.8. 14.x was released in August 2018 and has had several releases since 14.0.0. I think the main reason 14.x was released was to better follow semver and to "drop support for node v4 and v9". https://github.com/graphql/graphql-js/releases/tag/v14.0.0

In #1279, there's a new node library I want to add and it has a peer dependency on the latest graphql. If updating graphql doesn't work, I'll have to find an old version of this new library that supports 0.13.x.

Changelog Entry

Improvement - Updates graphql library to v14 from v0.13. (#1413)

Closing issues

Closes #1413

@JohnAlbin

This comment has been minimized.

Copy link
Contributor Author

JohnAlbin commented Nov 19, 2019

I'm hoping the tests don't fail as I don't have a reliable way to test them locally.

@JohnAlbin

This comment has been minimized.

Copy link
Contributor Author

JohnAlbin commented Nov 19, 2019

Screen Shot 2019-11-19 at 10 08 05 PM

sobs

@JohnAlbin

This comment has been minimized.

Copy link
Contributor Author

JohnAlbin commented Nov 19, 2019

Jenkins error shows:

FAILED - RETRYING: Drupal 8 composer PHP 7.0 - POSTGRES - Check if URL
 http://nginx.ci-drupal-postgres.drupal8-composer-70-postgres.192.168.99.100.xip.io
 contains content LAGOON_GIT_SHA=c2ac56fb554b56136b4bd7473ef71c9cce440d38
 (1 retries left).

fatal: [localhost]: FAILED! => {"attempts": 90, "cache_control": "no-cache",
 "changed": false, "connection": "close", "content": "<html><body><h1>504
 Gateway Time-out</h1>\nThe server didn't respond in time.\n</body></html>\n",
 "content_type": "text/html", "msg": "Status code was 504 and not [200]: HTTP
 Error 504: Gateway Time-out", "redirected": false, "status": 504,
 "url": "http://nginx.ci-drupal-postgres.drupal8-composer-70-postgres.192.168.99.100.xip.io"
}

Is this just a temporary error?

@JohnAlbin JohnAlbin force-pushed the 1413-upgrade-graphql branch from 795e4a8 to a88d2f8 Nov 19, 2019
@JohnAlbin

This comment has been minimized.

Copy link
Contributor Author

JohnAlbin commented Nov 19, 2019

I've kicked off another Jenkins test. keeps fingers crossed

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 19, 2019

@JohnAlbin
we see other tests also failing at postgres, so something is off there.
I'm currently investigating what is wrong there.

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Nov 19, 2019

found it: #1419

@JohnAlbin JohnAlbin force-pushed the 1413-upgrade-graphql branch from a88d2f8 to d265ac6 Nov 20, 2019
@JohnAlbin JohnAlbin requested a review from rocketeerbkw Nov 20, 2019
@JohnAlbin

This comment has been minimized.

Copy link
Contributor Author

JohnAlbin commented Nov 20, 2019

Tests passed!

@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 20, 2019
@Schnitzel Schnitzel merged commit 0dd4b28 into master Nov 20, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@JohnAlbin JohnAlbin deleted the 1413-upgrade-graphql branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.