Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications updates #1423

Merged
merged 17 commits into from Dec 16, 2019
Merged

Notifications updates #1423

merged 17 commits into from Dec 16, 2019

Conversation

@twardnw
Copy link
Member

twardnw commented Nov 20, 2019

Cleanup of several notifications-related tickets

closes #1272
closes #1274
closes #1319

@Schnitzel Schnitzel modified the milestones: v2.0.0, v1.2.0 Nov 26, 2019
tobybellwood and others added 6 commits Nov 26, 2019
@@ -394,7 +408,100 @@ async function createRemoveTask(removeData: Object) {

switch (project.activeSystemsRemove) {
case 'lagoon_openshiftRemove':
return sendToLagoonTasks('remove-openshift', removeData);
case 'lagoon_openshiftBuildDeploy':

This comment has been minimized.

Copy link
@Schnitzel

Schnitzel Dec 2, 2019

Member

I think this case 'lagoon_openshiftBuildDeploy': is too much here, it will never end up here, as project.activeSystemsRemove is never defined as this.

);
}
}
} else if (type === 'pullrequest') {

This comment has been minimized.

Copy link
@Schnitzel

Schnitzel Dec 2, 2019

Member

this is missing a type === 'promote' case, which means that environments of type promote are never deleted and therefore the CI fails. As promote environments are always created manually you can just assume that we can delete them like:

} else if (type === 'promote') {
  return sendToLagoonTasks('remove-openshift', removeData);
}
Schnitzel added 4 commits Dec 9, 2019
@Schnitzel Schnitzel merged commit 9fa278b into master Dec 16, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.