Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce keycloak requests for getAllProjects api query #1430

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@rocketeerbkw
Copy link
Member

rocketeerbkw commented Nov 26, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Running the getAllProjects api query can be very slow and error out when a user has access to a lot of projects. This is due to the fact that a keycloak authz request must be initiated for every environment of every project. The errors are exacerbated by the fact that apollo will run the resolvers in parallel, and may trigger the same async errors.

Since we already know the user has access to the project, and currently all roles are allowed to view all environments, this PR adds a hack to bypass keycloak for this use case.

This massively speeds up the /projects page in the UI, but may still be slow when running the api query directly and requesting deeper environment data.

Changelog Entry

Improvement - Speed up /projects page in UI (#1337)

Closing issues

n/a

rocketeerbkw and others added 2 commits Nov 26, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Nov 26, 2019
@Schnitzel Schnitzel merged commit 324f94a into master Nov 26, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@rocketeerbkw rocketeerbkw deleted the 1337-getAllProjects-slow branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.