Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub file timeout #1461

Merged
merged 4 commits into from Jan 29, 2020
Merged

Stub file timeout #1461

merged 4 commits into from Jan 29, 2020

Conversation

@shreddedbacon
Copy link
Member

shreddedbacon commented Dec 5, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Sometimes if the API is unavailable, drush will take a long time trying to get a token and eventually fail. This can cause issues with cronjobs and also some users that may be unable to generate a token.

This change defaults to a 10 second timeout, but it is adjustable client side with specifying an envvar LAGOON_OVERRIDE_SSH_TIMEOUT=10 or setting in ssh_port_timeout: 10 in .lagoon.yml

Changelog Entry

Improvement - The drush aliases stub file will timed out if api/ssh is unavailable

Closing issues

closes #1453

@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Dec 5, 2019

This only solves part of the problem at the moment, changing to draft

@Schnitzel Schnitzel modified the milestones: v1.2.0, v1.3.0 Dec 5, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Jan 13, 2020

@shreddedbacon
is this a draft? or do you think we can merge that?

@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Jan 13, 2020

I'll review this today

@shreddedbacon

This comment has been minimized.

Copy link
Member Author

shreddedbacon commented Jan 13, 2020

The other part of this has been added to the example drush aliases.
Basically checks that the aliases stub file is even accessible before attempting to use it, this will fail sooner if the stub file is completely unavailable like in the event that drush-aliases service is down or there is no active connection on the internet

@Schnitzel Schnitzel merged commit 378422d into amazeeio:master Jan 29, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.