Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of download button on Backups page. #1463 #1465

Merged
merged 1 commit into from Dec 13, 2019

Conversation

@JohnAlbin
Copy link
Contributor

JohnAlbin commented Dec 6, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated. n/a
  • Changelog entry has been written

The download button doesn't align the same was as other buttons do on the Backups page. Notice the lack of margins around the download button in the first screenshot below.

Before PR:
chrome_laptop_Components_Backups_Default

After PR:
chrome_laptop_Components_Backups_Default

Changelog Entry

Bugfix - Fix display of download button on Backups page (#1463)

Closing issues

closes #1463

@JohnAlbin JohnAlbin requested a review from rocketeerbkw Dec 6, 2019
@JohnAlbin JohnAlbin force-pushed the 1463-download-button branch 2 times, most recently from 793aee1 to 1be0339 Dec 10, 2019
@JohnAlbin

This comment has been minimized.

Copy link
Contributor Author

JohnAlbin commented Dec 12, 2019

Oops. I just noticed the buttons are still different heights. Button links are 20px tall, while Button buttons are 18px tall.

Edit: Fixed in latest commit.

@JohnAlbin JohnAlbin force-pushed the 1463-download-button branch from 1be0339 to 94c0266 Dec 12, 2019
@Schnitzel Schnitzel merged commit 8c37a73 into master Dec 13, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@JohnAlbin JohnAlbin deleted the 1463-download-button branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.