Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAFE_BRANCH and SAFE_PROJECT args build-deploy #1480

Merged
merged 2 commits into from Dec 13, 2019

Conversation

@shreddedbacon
Copy link
Member

shreddedbacon commented Dec 11, 2019

Currently LAGOON_GIT_BRANCH and LAGOON_PROJECT are passed as build args when building images, it would be good to have LAGOON_GIT_SAFE_BRANCH and LAGOON_SAFE_PROJECT versions of these too.

specific usecase

If images are pre-built elsewhere prior and pushed to a private container registry, being able to tag the image built in branch feature/xyz with the safe_branch like myproject/cli:feature-xyz.
This would allow using the LAGOON_GIT_SAFE_BRANCH build arg so that tagged images are used in the lagoon build step with a dockerfile like below.

ARG LAGOON_GIT_SAFE_BRANCH
FROM myregistry.com/myrepo/myproject/cli:${LAGOON_GIT_SAFE_BRANCH:-latest}
@tobybellwood tobybellwood added this to the v1.2.0 milestone Dec 13, 2019
@Schnitzel Schnitzel merged commit 6841484 into amazeeio:master Dec 13, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.