Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated harbor images #1486

Merged
merged 2 commits into from Dec 13, 2019
Merged

Remove duplicated harbor images #1486

merged 2 commits into from Dec 13, 2019

Conversation

@smlx
Copy link
Contributor

smlx commented Dec 12, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

It looks as though the harbor images have been duplicated in the services and images directories from what I could see the Dockerfiles etc. are identical.

I've removed them from images and updated the couple of place in the Makefile that referred to that location.

Changelog Entry

Improvement - Remove duplicate harbor images.

Closing issues

n/a

@smlx

This comment has been minimized.

Copy link
Contributor Author

smlx commented Dec 12, 2019

If I've made a mistake and the images are intentionally duplicated please close.

@Schnitzel Schnitzel requested a review from cdchris12 Dec 13, 2019
@Schnitzel Schnitzel added this to the v1.2.0 milestone Dec 13, 2019
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Dec 13, 2019

@cdchris12 can you please review?

Copy link
Contributor

cdchris12 left a comment

Looks good to me. These image links are artifacts from previous testing, and should've already been replaced by the correct images in the services folder.

@Schnitzel Schnitzel merged commit bb34a58 into master Dec 13, 2019
1 check was pending
1 check was pending
continuous-integration/jenkins/pr-merge This commit is being built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.