Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated billing helpers fix #1491

Conversation

@wintercreative
Copy link
Contributor

wintercreative commented Dec 12, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

The helper scripts for returning things like all projects not in billing groups were failing. This fixes that.

Changelog Entry

Automated billing helper script update

@wintercreative wintercreative force-pushed the wintercreative:feature/jw-automated-billing-helpers-fix branch from e323828 to bc6f711 Dec 12, 2019
@wintercreative wintercreative added this to the v1.2.0 milestone Dec 12, 2019
Copy link
Member

rocketeerbkw left a comment

It looks like there is a similar issue in https://github.com/amazeeio/lagoon/blob/master/services/api/src/models/project.ts#L33, which is only called from billingGroupsCost https://github.com/amazeeio/lagoon/blob/master/services/api/src/models/group.ts#L628. Do you wanna fix/test that in this PR also?

@wintercreative

This comment has been minimized.

Copy link
Contributor Author

wintercreative commented Dec 12, 2019

Updated.

@Schnitzel Schnitzel merged commit 8911526 into amazeeio:master Dec 13, 2019
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.