Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence useless "command not found" if minishift not installed #1502

Merged
merged 1 commit into from Jan 29, 2020

Conversation

@smlx
Copy link
Contributor

smlx commented Dec 18, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

If minishift is not installed locally the local-dev/minishift/minishift make target will print "command not found" on STDERR. This changes silences this useless error message.

Changelog Entry

Improvement - Silence useless error message in CI builds

Closing issues

n/a

Copy link
Contributor

tobybellwood left a comment

LGTM

@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 5, 2020
@smlx smlx force-pushed the silence-command-not-found branch from 2ba6437 to ce687be Jan 8, 2020
@smlx smlx force-pushed the silence-command-not-found branch from ce687be to 6d114a4 Jan 20, 2020
@smlx smlx force-pushed the silence-command-not-found branch from 6d114a4 to f1a9690 Jan 22, 2020
@Schnitzel Schnitzel merged commit 2d24bc6 into master Jan 29, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@smlx smlx deleted the silence-command-not-found branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.