Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests dependencies to run only once in the right order #1516

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@smlx
Copy link
Contributor

smlx commented Jan 2, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This change splits out duplicated imperative docker-compose commands into a few new .PHONY make targets. This leverages the make DAG to avoid running docker-compose commands to bring up the same containers more than once.

I tested it mostly by running make in debug mode and observing the ordering of the generated commands.

Changelog Entry

Bugfix - fix race condition in test suite.

Closing issues

Closes #1506

@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 5, 2020
Copy link
Contributor

tobybellwood left a comment

LGTM

@smlx smlx force-pushed the fix-test-ordering branch from aa94d76 to 639d1e2 Jan 8, 2020
@smlx smlx mentioned this pull request Jan 13, 2020
3 of 3 tasks complete
@Schnitzel Schnitzel merged commit 2036bb2 into master Jan 13, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@smlx smlx deleted the fix-test-ordering branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.