Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Python Alpine to 3.10 instead of latest #1517

Merged
merged 1 commit into from Jan 6, 2020
Merged

Conversation

@tobybellwood
Copy link
Contributor

tobybellwood commented Jan 3, 2020

As per #1514 - Python2 is no longer supported in Alpine 3.10

This PR pins the Alpine version for Python (2 and 3) to 3.10. It also adds a case switch into the dockerfile to handle the differing package dependencies for the two versions. This prevents Python 2.7 from also being installed into the Python3 version as a dependency of the python2 packages

python:/$ python -V
Python 3.7.5
python:/$ python2 -V
Python 2.7.16
python:/$ printenv | grep PYTHON_VERSION
PYTHON_VERSION=3.7.5

This change is ahead of a wider one to allow builds to continue. I will continue to look at alpine version pinning to avoid unwanted version upgrades/backward-compatibility issues

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Changelog Entry

Bugfix: Pin Python Alpine to 3.10 instead of latest

Closing issues

closes #1514

@smlx
smlx approved these changes Jan 3, 2020
Copy link
Contributor

smlx left a comment

LGTM and fixes the build

@Schnitzel Schnitzel merged commit 905d03a into master Jan 6, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 28, 2020
@tobybellwood tobybellwood deleted the python_alpine310 branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.