Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some ansible warnings in test suite #1520

Merged
merged 1 commit into from Jan 13, 2020
Merged

Fix some ansible warnings in test suite #1520

merged 1 commit into from Jan 13, 2020

Conversation

@smlx
Copy link
Contributor

smlx commented Jan 3, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

This PR updates parts of the test suite that were generating ansible warnings like this in the test output:

[WARNING]: when statements should not include jinja2 templating delimiters

Changelog Entry

Improvement - Avoid ansible warnings in CI

Closing issues

n/a

@smlx

This comment has been minimized.

Copy link
Contributor Author

smlx commented Jan 3, 2020

Build is broken pending #1517

@smlx smlx force-pushed the ansible-warnings branch from f0bd58d to 0badbb1 Jan 7, 2020
Copy link
Contributor

tobybellwood left a comment

looks good - less jinja whinging FTW

@smlx smlx mentioned this pull request Jan 13, 2020
3 of 3 tasks complete
@Schnitzel Schnitzel merged commit 1513c1f into master Jan 13, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Schnitzel Schnitzel added this to the v1.3.0 milestone Jan 13, 2020
@smlx smlx deleted the ansible-warnings branch Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.