Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Node versions 6, 8, and 9 and PHP versions 5.6, 7.0, and 7.1 #1521

Merged
merged 20 commits into from Feb 4, 2020

Conversation

@cdchris12
Copy link
Contributor

cdchris12 commented Jan 3, 2020

This PR removes support for old PHP and Node versions

Checklist

  • Documentation has been written/updated.
  • Changelog entry has been written

Changelog Entry

Change - Remove support for Node 6, 8, and 9 and for PHP 5.6, 7.0, and 7.1

@cdchris12 cdchris12 requested a review from Schnitzel Jan 3, 2020
@tobybellwood tobybellwood mentioned this pull request Jan 7, 2020
0 of 3 tasks complete
@cdchris12 cdchris12 self-assigned this Jan 8, 2020
@seanhamlin

This comment has been minimized.

Copy link
Contributor

seanhamlin commented Jan 17, 2020

Having this merged would have saved me a few hours as I went down a rabbit hole in #1554 to fix an issue with the PHP 7.0 images not building.

@tobybellwood

This comment has been minimized.

Copy link
Contributor

tobybellwood commented Jan 17, 2020

This looks really good - before approving, can we look at the following?

@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 17, 2020
@cdchris12 cdchris12 changed the title Removing Node versions 6 and 8 and PHP versions 5.6, 7.0, and 7.1 Removing Node versions 6, 8, and 9 and PHP versions 5.6, 7.0, and 7.1 Jan 17, 2020
@cdchris12

This comment has been minimized.

Copy link
Contributor Author

cdchris12 commented Jan 17, 2020

I've removed support for Node 9 and the nag notifications for depreciated versions in the Node Dockerfile.

@smlx

This comment has been minimized.

Copy link
Contributor

smlx commented Jan 17, 2020

According to this link all solr versions < 7.7 are also EOL - that means none of the versions we currently define are in support 😬 . I wonder if bumping solr versions should go in this PR or a separate one?

@tobybellwood

This comment has been minimized.

Copy link
Contributor

tobybellwood commented Jan 17, 2020

@smlx - solr is a whole other story/PR - the alpine-based images we use are also EOL...

Copy link
Contributor

tobybellwood left a comment

This looks good to me now, and will unblock a lot of the downstream image issues we've seen. We should flag the deprecation of Node 6/8/9 - we've already notified users about PHP5.6/7.0/7.1 in the last Lagoon 1.2.0 release

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Jan 29, 2020

the node6_subfolder actually tested the capability to have a Dockerfile in a Subfolder. with removing the node6 test we're removing also this test. I moved this test into the features-subfolder test now.

@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Jan 29, 2020

also I don't think we need to install xdebug in an older version anymore, as the newest version of xdebug supports 7.1 and newer: https://pecl.php.net/package/xdebug/2.9.1

cdchris12 and others added 4 commits Jan 29, 2020
@Schnitzel Schnitzel merged commit 0198657 into master Feb 4, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.