Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to a default alpine version (3.11) for _most_ images #1523

Merged
merged 7 commits into from Feb 5, 2020

Conversation

@tobybellwood
Copy link
Contributor

tobybellwood commented Jan 4, 2020

Initial draft of a way to pin a "default" Alpine version - currently 3.11 - for those images that currently utilise :latest.

It also pins specific older versions of alpine for specific images (php, node and python).

Sumbitting a draft to put it through testing - images build ok locally, but not tested (why use my CPU cycles!)

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Changelog Entry

Closing issues

Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@tobybellwood

This comment has been minimized.

Copy link
Contributor Author

tobybellwood commented Jan 4, 2020

List of issues for follow up

  • mariadb (alpine3.8) - 3.10 seems incompatible with api_db [DEBUG]
  • varnish (alpine3.7) - 3.10 has varnish 6.2 - needs libvmod plugin updates (dynamic from same repo, bodyaccess now via varnish-modules) [UPDATE]
  • mongodb (alpine3.9) - no longer available in 3.10 [WORKAROUND?]

some upstream images don't permit alpine version pinning in the dockerfile - these have been semver pinned to minor releases

  • nginx,postgres,rabbitmq - version documented in Dockerfile
  • solr - alpine no longer supported as official image (stretch/slim only)
images/nginx/Dockerfile Outdated Show resolved Hide resolved
@tobybellwood tobybellwood changed the title Pin to a default alpine version for _most_ images Pin to a default alpine version (3.11) for _most_ images Jan 29, 2020
@tobybellwood tobybellwood force-pushed the tobybellwood:image_pinning branch 2 times, most recently from d04702b to 556a8e0 Feb 2, 2020
images/mongo/Dockerfile Outdated Show resolved Hide resolved
@tobybellwood tobybellwood force-pushed the tobybellwood:image_pinning branch from 2b74f05 to 0c0f226 Feb 5, 2020
@tobybellwood tobybellwood marked this pull request as ready for review Feb 5, 2020
@tobybellwood tobybellwood added this to the v1.3.0 milestone Feb 5, 2020
Copy link
Member

Schnitzel left a comment

wow very nice :)

@Schnitzel Schnitzel merged commit 03bf436 into amazeeio:master Feb 5, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.