Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the securityadmin demo script as part of make up #1525

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@smlx
Copy link
Contributor

smlx commented Jan 6, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

When running make up, the logs-db container will not be available until the securityadmin_demo.sh script has been executed as per https://lagoon.readthedocs.io/en/latest/administering_lagoon/install/#opendistrosecurity

This change automates that step for local development.

It also removes the initial docker-compose up of api-db which doesn't seem to be necessary.

Changelog Entry

Improvement - Automate Elastic OpenDistro Security setup for local lagoon development

Closing issues

n/a

@shreddedbacon

This comment has been minimized.

Copy link
Member

shreddedbacon commented Jan 6, 2020

Might also be worth when starting minishift to also configure the external service with the following to leverage logging locally in the lagoon namespace

apiVersion: v1
kind: Service
metadata:
  name: application-logs
spec:
  externalName: 192.168.42.1
  sessionAffinity: None
  type: ExternalName
@smlx

This comment has been minimized.

Copy link
Contributor Author

smlx commented Jan 6, 2020

@shreddedbacon as discussed lets put that in a separate PR

@smlx smlx force-pushed the make-up-securityadmin branch from 9021484 to a8bfd23 Jan 7, 2020
@smlx smlx mentioned this pull request Jan 13, 2020
3 of 3 tasks complete
@Schnitzel Schnitzel merged commit d45da4a into master Jan 13, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Jan 13, 2020

Actually I really would like this to run automatically also when you deploy Lagoon, as we had issues with Lagoon develop before, so I created #1548

@smlx smlx deleted the make-up-securityadmin branch Jan 20, 2020
@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.