Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid piping to head where possible #1529

Merged
merged 1 commit into from Feb 4, 2020
Merged

Avoid piping to head where possible #1529

merged 1 commit into from Feb 4, 2020

Conversation

@smlx
Copy link
Contributor

smlx commented Jan 6, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

Piping to head may cause the preceding command to receive a SIGPIPE if it sends lines too slowly. Where that preceding command is jq, we can use built-in functionality instead.

See #1528 for details.

Changelog Entry

Bugfix - race condition in deployment script (#1528)

Closing issues

Closes #1528

@smlx smlx force-pushed the avoid-pipe-to-head branch 2 times, most recently from 9f5f1c6 to 6ed1e01 Jan 6, 2020
@smlx smlx force-pushed the avoid-pipe-to-head branch from 6ed1e01 to 4145d63 Jan 20, 2020
@smlx smlx requested a review from Schnitzel Jan 20, 2020
Piping to head may cause the preceding command to receive a SIGPIPE if
it sends lines too slowly. Where that preceding command is jq, we can
use built-in functionality instead.
@smlx smlx force-pushed the avoid-pipe-to-head branch from 4145d63 to 46564ae Jan 22, 2020
@tobybellwood tobybellwood added this to the v1.3.0 milestone Feb 4, 2020
@Schnitzel Schnitzel merged commit d8ea338 into master Feb 4, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@smlx smlx deleted the avoid-pipe-to-head branch Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.