Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional check for newrelic when container starts #1532

Merged
merged 1 commit into from Jan 29, 2020

Conversation

@shreddedbacon
Copy link
Member

shreddedbacon commented Jan 7, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

When starting tasks using the CLI image (drush cache-clear, etc) newrelic doesn't start fast enough for the command and can cause them to fail. This adds a check to the entrypoint for newrelic to wait for newrelic to start, it adds a delay of a few seconds to container starts

Changelog Entry

Bugfix - Check newrelic is started (if enabled) in the CLI image before doing any tasks

Closing issues

Closes #1527

…tasks can fail or display errors if it isnt running fast enough
@smlx

This comment has been minimized.

Copy link
Contributor

smlx commented Jan 20, 2020

@tobybellwood could we make sure this gets into the next release? (customer request)

@shreddedbacon shreddedbacon added this to the v1.3.0 milestone Jan 28, 2020
@Schnitzel Schnitzel merged commit a45784f into amazeeio:master Jan 29, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.