Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SSH public key in Lagoon UI. #1552

Merged
merged 8 commits into from Feb 1, 2020

Conversation

@justinlevi
Copy link
Contributor

justinlevi commented Jan 16, 2020

Adds a minimal ui to manage developer SSH Keys via the lagoon UI.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Managing sshkeys required graphql mutations to be run directly on the API which wasn't as user friendly as it could be.

Closing issues

closes #1471

Copy link
Member

rocketeerbkw left a comment

Some minor non-functional potential issue (didn't test in-browser). Could easily be handled in a follow-up issue though.

services/ui/src/components/SshKeys/AddSshKey.js Outdated Show resolved Hide resolved
services/ui/src/components/SshKeys/AddSshKey.js Outdated Show resolved Hide resolved
services/ui/src/components/SshKeys/AddSshKey.js Outdated Show resolved Hide resolved
services/ui/src/components/SshKeys/AddSshKey.js Outdated Show resolved Hide resolved
services/ui/src/components/SshKeys/AddSshKey.js Outdated Show resolved Hide resolved
Schnitzel added a commit that referenced this pull request Jan 21, 2020
 Update the SSH public key in Lagoon UI.
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented Jan 27, 2020

@justinlevi
can you have a look at the suggestions of @rocketeerbkw? and if you agree fix&commit them?
thanks

@justinlevi

This comment has been minimized.

Copy link
Contributor Author

justinlevi commented Jan 28, 2020

All issues should be addressed in justinlevi@bc97010

@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 29, 2020
@Schnitzel Schnitzel merged commit 8bbc71c into amazeeio:master Feb 1, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.