Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update New Relic PHP Agent to 9.6.0.255 and pin Xdebug to 2.6.0 for PHP 7.0 #1554

Merged
merged 2 commits into from Jan 21, 2020

Conversation

@seanhamlin
Copy link
Contributor

seanhamlin commented Jan 17, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Updated the version of the PHP Agent to be the latest stable release. https://docs.newrelic.com/docs/release-notes/agent-release-notes/php-release-notes

Version 9.4 added support for PHP 7.4, and at the moment New Relic is in those images. So now it will actually work.

Had to also downgrade Xdebug to 2.6.0 on the PHP 7.0 images so that they would actually build.

Closing issues

Closes #1543`.

…c PHP Agent added in this release.
@smlx

This comment has been minimized.

Copy link
Contributor

smlx commented Jan 17, 2020

It is strongly recommended that users use an explicit version number in their pecl install invocations to ensure proper PHP version compatibility (PECL does not check the PHP version compatiblity when choosing a version of the extension to install, but does when trying to install it).

For example, memcached-2.2.0 has no PHP version constraints (https://pecl.php.net/package/memcached/2.2.0), but memcached-3.1.4 requires PHP 7.0.0 or newer (https://pecl.php.net/package/memcached/3.1.4). When doing pecl install memcached (no specific version) on PHP 5.6, PECL will try to install the latest release and fail.

Beyond the compatibility issue, it's also a good practice to ensure you know when your dependencies receive updates and can control those updates directly.

https://hub.docker.com/_/php

.. so I guess we should be pinning all the pecl packages?

@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 17, 2020
@tobybellwood tobybellwood changed the title Update New Relic PHP Agent to 9.6.0.255. PHP 7.4 support for New Relic PHP Agent added in this release. Update New Relic PHP Agent to 9.6.0.255 and pin Xdebug to 2.6.0 for PHP 7.0 Jan 20, 2020
Copy link
Member

dasrecht left a comment

Builds locally and on CI, looks good to me

@dasrecht dasrecht merged commit a391f6d into master Jan 21, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Schnitzel added a commit that referenced this pull request Jan 21, 2020
Update New Relic PHP Agent to 9.6.0.255 and pin Xdebug to 2.6.0 for PHP 7.0
@seanhamlin seanhamlin deleted the newrelic-upgrade branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.