Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also delete branches and pull requests that do not match the supplied regex. #1576

Merged
merged 1 commit into from Jan 27, 2020

Conversation

@seanhamlin
Copy link
Contributor

seanhamlin commented Jan 22, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Closing issues

closes #1560

…o still be removed from OpenShift.
@Schnitzel Schnitzel requested a review from rocketeerbkw Jan 23, 2020
@Schnitzel Schnitzel merged commit b56838b into master Jan 27, 2020
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@tobybellwood tobybellwood added this to the v1.3.0 milestone Jan 28, 2020
@tobybellwood tobybellwood changed the title All branches and pull requests that do not match the supplied regex to still be removed from OpenShift Also delete branches and pull requests that do not match the supplied regex. Jan 28, 2020
@seanhamlin seanhamlin deleted the delete-branch-env-fix branch Jan 28, 2020
@Schnitzel

This comment has been minimized.

Copy link
Member

Schnitzel commented on tests/tests/github.yaml in 8c70e3b Mar 28, 2020

@seanhamlin
looking at this again I realize that we actually don't use ci-github-picky but ci-github, so this never deploys against the project that you created :(
let's talk next week what exactly this should test, so we can fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.