Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates Round 2! #1630

Merged
merged 54 commits into from Feb 12, 2020
Merged

Documentation updates Round 2! #1630

merged 54 commits into from Feb 12, 2020

Conversation

@AlannaBurke
Copy link
Contributor

AlannaBurke commented Feb 4, 2020

Documentation updates! This includes typo cleanup, language simplification, and more!

If you have access to readthedocs, I also built a private version for review here: https://lagoon.readthedocs.io/en/documentation-updates

@AlannaBurke AlannaBurke requested a review from tobybellwood Feb 4, 2020
@tobybellwood tobybellwood added this to the v1.3.0 milestone Feb 4, 2020
docs/using_lagoon/index.md Outdated Show resolved Hide resolved
docs/using_lagoon/index.md Outdated Show resolved Hide resolved
docs/using_lagoon/index.md Outdated Show resolved Hide resolved
@tobybellwood

This comment has been minimized.

Copy link
Contributor

tobybellwood commented Feb 5, 2020

sorry @AlannaBurke - a heap of version nitpicks in as suggestions - a couple of updates, but mostly semver consistency - let's list out the minor versions, instead of patch (removing some maintenance overhead)

AlannaBurke and others added 14 commits Feb 5, 2020
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
Co-Authored-By: Toby Bellwood <toby.bellwood@finance.gov.au>
@AlannaBurke

This comment has been minimized.

Copy link
Contributor Author

AlannaBurke commented Feb 6, 2020

@tobybellwood no apologies needed! thanks for the details, that's stuff i'm not going to know!

@AlannaBurke

This comment has been minimized.

Copy link
Contributor Author

AlannaBurke commented Feb 6, 2020

Ok, I've reviewed every file, and checked every page both locally and on readthedocs. If there's any errors to be found, I'm not going to find them now! Bless anyone who reviews this enormous thing, try the rich text diff.

@AlannaBurke AlannaBurke requested review from smlx and tobybellwood Feb 6, 2020
Copy link
Contributor

tobybellwood left a comment

more great work

@Schnitzel Schnitzel merged commit 1d467e4 into master Feb 12, 2020
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.