Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the shared cleanup script to support multiple ASB configs, also deal with the read replica support #1650

Merged
merged 1 commit into from Feb 12, 2020

Conversation

@seanhamlin
Copy link
Contributor

seanhamlin commented Feb 10, 2020

Update the shared cleanup script to

  • support multiple ASB configs
  • deal with the read replicas

Also, there now is additional checks for whether each database is likely in use, and a SQL statement printed that you can use to drop the databases in question.

This has been tested to work on multiple RDS clusters.

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied
…o deal with the read replica support. Additional checks for whether each database is likely in use, and a SQL statement to drop the databases in question.
@seanhamlin seanhamlin requested a review from smlx Feb 10, 2020
@smlx
smlx approved these changes Feb 10, 2020
Copy link
Contributor

smlx left a comment

LGTM and most importantly it's been tested against RDS already

@tobybellwood tobybellwood added this to the v1.3.0 milestone Feb 10, 2020
@Schnitzel Schnitzel merged commit 817def9 into master Feb 12, 2020
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.