Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logs2logs-db to create missing lagoon-logs exchange #1691

Merged
merged 1 commit into from Mar 12, 2020

Conversation

@rocketeerbkw
Copy link
Member

rocketeerbkw commented Feb 28, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

When developing locally, it's possible to start lagoon images in an order which makes the logs2logs-db service constantly spit out errors:

logs2logs-db_1                   | [2020-02-28T06:56:12,995][WARN ][logstash.inputs.rabbitmq ]
Error while setting up connection for rabbitmq input! Will retry.
{:message=>"#method<channel.close>(reply-code=404, reply-text=NOT_FOUND - no exchange 'lagoon-logs' in vhost '/', class-id=50, method-id=20)",
:class=>"MarchHare::ChannelAlreadyClosed", :location=>"/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/march_hare-3.1.1-java/lib/march_hare/exceptions.rb:121:in `convert_and_reraise'"}

This is because the lagoon-logs rabbitmq exchange may not exist yet (if the api hasn't started and declared it yet, for example). It's possible to configure the logstash pipeline in a way that will allow it to create the rabbitmq exchange if it doesn't yet exist.

Closing issues

n/a

@rocketeerbkw rocketeerbkw added this to the v1.4.0 milestone Mar 11, 2020
@Schnitzel Schnitzel merged commit 4e3fe12 into master Mar 12, 2020
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@Schnitzel Schnitzel modified the milestones: v1.4.0, v1.3.1 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.