Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared cleanup script bug fix #1700

Merged
merged 1 commit into from Mar 6, 2020
Merged

Shared cleanup script bug fix #1700

merged 1 commit into from Mar 6, 2020

Conversation

@seanhamlin
Copy link
Contributor

seanhamlin commented Mar 3, 2020

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated
  • PR title is ready for changelog and subsystem label(s) applied

Explain the details for making this change. What existing problem does the pull request solve?

Due to set -u the script will throw an error if there are no ERRORs found in the script. The fix is simple.

@Schnitzel Schnitzel merged commit 61bf99c into master Mar 6, 2020
1 check failed
1 check failed
continuous-integration/jenkins/pr-merge This commit cannot be built
Details
@seanhamlin seanhamlin deleted the sharedcleanup-fix branch Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.