Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
this is going to fix lagoon issue #461 #463
@thom8 changed has been made according to what you suggested, build was successful but test failed on CI, which is quite hard for me to identify what exactly is the error.
Can you please advise what the possible error is ? The change I made is just a very simple change.
I don't think this will have the requested result, see:
PERSISTENT_STORAGE_CLASS is only added when
PERSISTENT_STORAGE_PATH is also set.
I'm happy though to move the check for
PERSISTENT_STORAGE_CLASS out of the wrapping if in order to allow the usecase here.
Hi @Schnitzel ,
Thank you for the information.
When I use it from dockercompose file, I should use below lables, am I correct ?
where can I find the mapping between the lables and parameters in the pvc.yml ?
So there are two systems in place here:
On the other side, for elasticsearch we DON'T want the developers to define the path, as elasticsearch expects the path of the persistent storage always to be at
So that's why I am suggesting to move the adding of the parameters here:
outside of the
makes sense? Happy to do that part in
that also happens here: