Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#537 - change solr to no lock #552
#537 - change solr to no lock #552
Changes from 15 commits
32672c5
fbf1989
e4984f3
d6ea8b8
13da91c
3e29923
41c54dc
280871c
d70602f
2ba5f78
d3a4e65
375c8c4
168e104
08df593
5fa6746
63a7061
31b0190
797ae20
cf9c132
6117f93
3b2b8c3
2515651
7a77787
303295f
61287b1
4445358
051498a
d731384
3c9bc97
9abc2a8
4ef0eb0
1364290
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we add a new git repo, but is there also a new test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started; but then I realized I wasn't testing the feature that I was developing, only that solr came up and could index and search.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better than nothing :) how far are you? happy to get this change in and add the tests later