New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file storage to API and save task artifacts there #820

Merged
merged 17 commits into from Jan 14, 2019

Conversation

Projects
None yet
2 participants
@rocketeerbkw
Copy link
Member

rocketeerbkw commented Dec 21, 2018

Fixes #805
Includes #801 and #794

API service requires new environment variables to connect to an S3 compatible file storage service:

  • S3_HOST
  • S3_ACCESS_KEY_ID
  • S3_SECRET_ACCESS_KEY
  • S3_BUCKET

API has a new mutation uploadFilesForTask which can accept files and save them to file store. Tasks have a new files field to retrieve files. There is a new File type which represents files from the storage system. The download link generated is only valid for 15 mins.

openshiftjobs service now generates an API token, valid only for the project the task was created in, and valid only for 1 day, for use by the task to upload files to the API.

UI now shows a list of files on the task page if files are available.

TODO:

  • UI could use a new logo for files on the task page

image

@rocketeerbkw rocketeerbkw force-pushed the 805-task-file-storage branch from e8a15bc to eba8d08 Dec 21, 2018

Schnitzel added a commit that referenced this pull request Dec 31, 2018

Merge pull request #820 from amazeeio/805-task-file-storage
Add file storage to API and save task artifacts there

@rocketeerbkw rocketeerbkw referenced this pull request Jan 10, 2019

Merged

Run tasks from ui #845

@Schnitzel Schnitzel merged commit eba8d08 into master Jan 14, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@rocketeerbkw rocketeerbkw deleted the 805-task-file-storage branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment