Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip PR deployments if only the body has changed #870

Merged
merged 2 commits into from Feb 27, 2019

Conversation

Projects
None yet
2 participants
@rocketeerbkw
Copy link
Member

rocketeerbkw commented Jan 29, 2019

Checklist

  • Affected Issues have been mentioned in the Closing issues section
  • Documentation has been written/updated.
  • Changelog entry has been written

In order to reduce the number of unnecessary deploys for some clients, this change will not re-deploy a PR if it detects that only the body has changed. Title and code changes will still trigger a deploy.

While making this change, I noticed that several log messages were copy/pasted but the text didn't match very well to the logging action. I have also updated the log messages.

I didn't see anywhere that needed documentation changes.

Changelog Entry

Improvement - Skip github PR deployments if only the body has changed (#601)
Improvement - Log messages related to PR tasks are more consistent

Closing issues

Closes #601

Schnitzel added a commit that referenced this pull request Feb 26, 2019

Merge pull request #870 from amazeeio/601-skip-deploy-pr-body-changes
Skip PR deployments if only the body has changed

@Schnitzel Schnitzel merged commit 48713ba into master Feb 27, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.